feat(#753): Fix The Problem With The First Digit Naming #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 Would you mind looking at this PR, please? |
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 8min). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fixed the name genearation strategy for sequences of values. Now all the randomly generated names will start with a letter.
Closes: #753.
History:
PR-Codex overview
This PR introduces a new feature to generate random names for
DirectivesValues, ensuring they do not start with a digit. It also adds a test case to validate this behavior.Detailed summary
DIGITSinDirectivesValuesto identify leading digits.randomName()method inDirectivesValuesto generate valid random names.generatesRandomNameWithoutFirstDigit()inDirectivesValuesTestto validate the random name generation.